-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update refractor to 4.1.0 #10
Comments
@BrendanThompson yeah it's an easy change I think I will do it in the next few days. Unless you want to give it a try and I can help you out. |
@j0lv3r4 – I think it would probably best if I just let you do it to be honest. |
Hey @j0lv3r4 – I don't suppose you've had any opportunity to do this have you? |
Hi @j0lv3r4 I'm interesting in helping get this updated, as FAIL ./test.js
● Test suite failed to run
/Volumes/workplace/mdx-prism/node_modules/refractor/index.js:8
export {refractor} from './lib/common.js'
^^^^^^
SyntaxError: Unexpected token 'export' Examing the |
Sorry, I misunderstood what you said. I have no idea honestly. do you have any recommendations? I don't have experience moving a library to ESM. |
@reesscot OK, so I have an idea of how to do it. I think we need to do a major release and move entirely to ESM. The reason is that our main dependency already did it, so I guess it makes sense for us to do it. Even if we tried to keep it a dual CJS/ESM module, the main dependency has already moved on. Resources:
|
Would it be possible have this using Refractor 4.1.0 as there are a few more languages in there as well as an updated version of Prism.
I did fork this to attempt myself, but unfortunately my JS skills are trash.
The text was updated successfully, but these errors were encountered: