Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate mode for providesConcept where providing concepts have to be explicitly enabled to be used #617

Open
SebastianWendorf opened this issue Aug 22, 2024 · 1 comment
Labels
Milestone

Comments

@SebastianWendorf
Copy link
Contributor

No description provided.

@DirkMahler DirkMahler added this to the 2.6 milestone Aug 23, 2024
@DirkMahler
Copy link
Member

There is a trade-off between convenience and level of control: currently every providing concept is enabled implicitly, i.e. when its available in the rules, locally or from a plugin. So there's no need to explicit adding them to groups but they might be enabled unintentionally and create an unwanted situation.

My current thoughts are as follows:

  • providing concepts which are available locally (i.e. in the rules folder jqassistant) should be activated by default, the concepts are here by intention
  • provding concepts which are available from plugins should be enabled exclicitly, e.g. by adding them to a group
  • there should be an activation policy for providing concepts (as attribute activation on providesConcept) to control this behavior, e.g. with the following strategies:
    • local, plugin: as described
    • always: the concept should be activated whenever it is available, this makes sense e.g. for concepts providing java:GeneratedType
    • explict: the concept must be activated explicitly, e.g. by adding it to a group

@DirkMahler DirkMahler modified the milestones: 2.6, 3.0 Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants