Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jackdbus wakes up every 200ms #962

Open
StefanBruens opened this issue Dec 13, 2023 · 0 comments · May be fixed by #963
Open

Jackdbus wakes up every 200ms #962

StefanBruens opened this issue Dec 13, 2023 · 0 comments · May be fixed by #963
Labels
bug

Comments

@StefanBruens
Copy link

Even when jackdbus is just listening for DBus events it continuously wakes up every 200 ms.

Environment

  • JACK Version: 1.9.22
  • Operating System: Linux (openSUSE Tumbleweed 20231212)
  • Installation: Distribution packages

Steps To Reproduce

Start jackbus
Attach strace

Expected vs. actual behavior

When jackdbus is idle, it should not wake up.

Waking up, even when there are no actual events pending, shortens runtime on battery. This is especially important as jackdbus is often just running in the background.

jack2/dbus/jackdbus.c

Line 950 in 886b35c

while (!g_exit_command && dbus_connection_read_write_dispatch (g_connection, 200))

The only actual need for the timed wakeup is a pending save.
StefanBruens added a commit to StefanBruens/jack2 that referenced this issue Dec 13, 2023
@StefanBruens
jackdbus: Stop recurrent wakeups when no save is pending
fd1ac14 
Most processing happens as a result of an incoming
DBus event. The only case when a timed processing
is needed is due to an pending save.

Instead of implementing a full event loop just run the
timed loop while a save is pending, and use an
infinite timeout otherwise.

Fixes: jackaudio#962
@StefanBruens StefanBruens linked a pull request Dec 13, 2023 that will close this issue
Open
nedko pushed a commit to LADI/jackdbus that referenced this issue Aug 26, 2024
@StefanBruens @nedko
jackdbus: Stop recurrent wakeups when no save is pending
9a7668a 
Most processing happens as a result of an incoming
DBus event. The only case when a timed processing
is needed is due to an pending save.

Instead of implementing a full event loop just run the
timed loop while a save is pending, and use an
infinite timeout otherwise.

Fix for jackaudio/jack2#962

Thanks you @StefanBruens

(cherry picked from commit fd1ac1422460c02cba17ea3053a4e6517290750c)
nedko pushed a commit to LADI/jackdbus that referenced this issue Aug 26, 2024
@StefanBruens @nedko
jackdbus: Stop recurrent wakeups when no save is pending
aef0259 
Most processing happens as a result of an incoming
DBus event. The only case when a timed processing
is needed is due to an pending save.

Instead of implementing a full event loop just run the
timed loop while a save is pending, and use an
infinite timeout otherwise.

Fix for jackaudio/jack2#962

Thanks @StefanBruens

(cherry picked from commit fd1ac1422460c02cba17ea3053a4e6517290750c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

jackdbus: Stop recurrent wakeups when no save is pending StefanBruens/jack2
1 participant
@StefanBruens