We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ScalaRunnableWrapper
akka.dispatch.Batchable
Hello! Thanks for the awesome library.
I have a question regarding ScalaRunnableWrapper for Scala 2.13:
akka-sensors/sensors-core/src/main/scala-2.13/akka/sensors/dispatch/ScalaRunnableWrapper.scala
Lines 3 to 16 in 82f28d1
According to the code, the match expects the akka.dispatch.Batchable type. Then, AkkaRunnableWrapper relies on akka.dispatch.Batchable too.
AkkaRunnableWrapper
akka-sensors/sensors-core/src/main/scala/akka/sensors/dispatch/InstrumentedDispatchers.scala
Line 61 in 82f28d1
If I get it right, the case case ScalaRunnableWrapper(runnable) => runnable(r) will never happen.
case ScalaRunnableWrapper(runnable) => runnable(r)
Lines 106 to 111 in 82f28d1
I assume, ScalaRunnerWrapper should import scala.concurrent.Batchable instead?
ScalaRunnerWrapper
scala.concurrent.Batchable
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hello! Thanks for the awesome library.
I have a question regarding
ScalaRunnableWrapper
for Scala 2.13:akka-sensors/sensors-core/src/main/scala-2.13/akka/sensors/dispatch/ScalaRunnableWrapper.scala
Lines 3 to 16 in 82f28d1
According to the code, the match expects the
akka.dispatch.Batchable
type. Then,AkkaRunnableWrapper
relies onakka.dispatch.Batchable
too.akka-sensors/sensors-core/src/main/scala/akka/sensors/dispatch/InstrumentedDispatchers.scala
Line 61 in 82f28d1
If I get it right, the case
case ScalaRunnableWrapper(runnable) => runnable(r)
will never happen.akka-sensors/sensors-core/src/main/scala/akka/sensors/dispatch/InstrumentedDispatchers.scala
Lines 106 to 111 in 82f28d1
I assume,
ScalaRunnerWrapper
should importscala.concurrent.Batchable
instead?The text was updated successfully, but these errors were encountered: