Remove support for OTEL spanmetrics processor

docker-compose/monitor/Makefile

@@ -12,17 +12,6 @@ dev: export JAEGER_IMAGE_TAG = dev
 dev:
 	docker compose -f docker-compose.yml up
 
-# starts older spanmetrics processor setup, for example,
-# to test backwards compatibility of Jaeger with spanmetrics processor.
-.PHONY: dev-processor
-dev-processor: export JAEGER_IMAGE_TAG = dev
-# Fix to a version before the breaking changes were introduced.
-dev-processor: export OTEL_IMAGE_TAG = 0.70.0
-dev-processor: export OTEL_CONFIG_SRC = ./otel-collector-config-processor.yml
-dev-processor: export PROMETHEUS_QUERY_SUPPORT_SPANMETRICS_CONNECTOR = false
-dev-processor:
-	docker compose -f docker-compose.yml up
-
 .PHONY: clean-jaeger
 clean-jaeger:
 	# Also cleans up intermediate cached containers.

docker-compose/monitor/README.md

@@ -15,7 +15,7 @@ This environment consists the following backend components:
 
 - [MicroSim](https://github.com/yurishkuro/microsim): a program to simulate traces.
 - [Jaeger All-in-one](https://www.jaegertracing.io/docs/1.24/getting-started/#all-in-one): the full Jaeger stack in a single container image.
-- [OpenTelemetry Collector](https://opentelemetry.io/docs/collector/): vendor agnostic integration layer for traces and metrics. Its main role in this particular development environment is to receive Jaeger spans, forward these spans untouched to Jaeger All-in-one while simultaneously aggregating metrics out of this span data. To learn more about span metrics aggregation, please refer to the [spanmetrics processor documentation][spanmetricsprocessor].
+- [OpenTelemetry Collector](https://opentelemetry.io/docs/collector/): vendor agnostic integration layer for traces and metrics. Its main role in this particular development environment is to receive Jaeger spans, forward these spans untouched to Jaeger All-in-one while simultaneously aggregating metrics out of this span data. To learn more about span metrics aggregation, please refer to the [spanmetrics connector documentation](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/connector/spanmetricsconnector/README.md).
 - [Prometheus](https://prometheus.io/): a metrics collection and query engine, used to scrape metrics computed by OpenTelemetry Collector, and presents an API for Jaeger All-in-one to query these metrics.
 - [Grafana](https://grafana.com/): a metrics visualization, analytics & monitoring solution supporting multiple metrics databases.
 
@@ -65,7 +65,7 @@ make build
 make dev
 ```
 
-## Backwards compatibility testing with spanmetrics processor
+## Backwards compatibility testing with spanmetrics connector
 
 ```bash
 make dev-processor

plugin/metrics/prometheus/factory_test.go

@@ -59,16 +59,6 @@ func TestWithDefaultConfiguration(t *testing.T) {
 }
 
 func TestWithConfiguration(t *testing.T) {
-	t.Run("still supports the deprecated spanmetrics processor", func(t *testing.T) {
-		f := NewFactory()
-		v, command := config.Viperize(f.AddFlags)
-		err := command.ParseFlags([]string{
-			"--prometheus.query.support-spanmetrics-connector=false",
-		})
-		require.NoError(t, err)
-		f.InitFromViper(v, zap.NewNop())
-		assert.False(t, f.options.Primary.SupportSpanmetricsConnector)
-	})
 	t.Run("with custom configuration and no space in token file path", func(t *testing.T) {
 		f := NewFactory()
 		v, command := config.Viperize(f.AddFlags)

plugin/metrics/prometheus/options.go

@@ -17,7 +17,6 @@ package prometheus
 import (
 	"flag"
 	"fmt"
-	"log"
 	"strings"
 	"time"
 
@@ -48,8 +47,6 @@ const (
 	defaultLatencyUnit                 = "ms"
 	defaultNormalizeCalls              = false
 	defaultNormalizeDuration           = false
-
-	deprecatedSpanMetricsProcessor = "(deprecated, will be removed after 2024-01-01 or in release v1.53.0, whichever is later) "
 )
 
 type namespaceConfig struct {
@@ -97,7 +94,7 @@ func (opt *Options) AddFlags(flagSet *flag.FlagSet) {
 	flagSet.Bool(
 		nsConfig.namespace+suffixSupportSpanmetricsConnector,
 		defaultSupportSpanmetricsConnector,
-		deprecatedSpanMetricsProcessor+" Controls whether the metrics queries should match the OpenTelemetry Collector's spanmetrics connector naming (when true) or spanmetrics processor naming (when false).")
+		" Controls the metrics queries should match the OpenTelemetry Collector's spanmetrics connector naming.")
 	flagSet.String(nsConfig.namespace+suffixMetricNamespace, defaultMetricNamespace,
 		`The metric namespace that is prefixed to the metric name. A '.' separator will be added between `+
 			`the namespace and the metric name.`)
@@ -128,9 +125,6 @@ func (opt *Options) InitFromViper(v *viper.Viper) error {
 	cfg.TokenFilePath = v.GetString(cfg.namespace + suffixTokenFilePath)
 
 	cfg.SupportSpanmetricsConnector = v.GetBool(cfg.namespace + suffixSupportSpanmetricsConnector)
-	if !cfg.SupportSpanmetricsConnector {
-		log.Printf("using Spanmetrics Processor's metrics naming conventions " + deprecatedSpanMetricsProcessor)
-	}
 	cfg.MetricNamespace = v.GetString(cfg.namespace + suffixMetricNamespace)
 	cfg.LatencyUnit = v.GetString(cfg.namespace + suffixLatencyUnit)
 	cfg.NormalizeCalls = v.GetBool(cfg.namespace + suffixNormalizeCalls)