-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better graph selection api #33
Comments
Didn't end up with that approach, but the new selector api is much nicer to write complex patterns with. Rope went from
To
Still some correctness bugs remaining. The selector graphs currently cannot reference the same node twice, because the backtracking function doesn't support it yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the graph selection api makes it difficult to write selectors for complex patterns like Rope:
luminal/crates/luminal_metal/src/unary.rs
Line 1278 in cb07523
Selectors should be built similarly to how primgraphs are already built, with a graphtensor-like api (no compile-time shapes though).
The text was updated successfully, but these errors were encountered: