Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify what Faces should do when f:metadata is not a direct child of f:view #1849

Open
BalusC opened this issue Sep 23, 2023 · 4 comments
Open
Milestone

Comments

@BalusC
Copy link
Member

BalusC commented Sep 23, 2023

eclipse-ee4j/mojarra#5105 (comment)

There are basically 3 options:

  1. ignore f:metadata and log warning
  2. use f:metadata but log warning
  3. throw exception
@BalusC
Copy link
Member Author

BalusC commented Sep 23, 2023

For the record, there are more API concerns about f:metadata in general:

@BalusC
Copy link
Member Author

BalusC commented Sep 3, 2024

Mojarra impl does currently 2 (implemented via https://github.com/eclipse-ee4j/mojarra/pull/5179/files)
MyFaces impl does currently 3.

We should probably set 3 in spec.
cc: @tandraschko

@tandraschko
Copy link

should we really do that?
Or isnt it better to implement it not that strict?

@BalusC
Copy link
Member Author

BalusC commented Sep 3, 2024

The spec says that it must be a direct child of f:view but the spec does not say what to do otherwise. If we don't throw exception then we basically allow that it doesn't need to be a direct child of f:view and this may cause problems/confusion in long term.

see also eclipse-ee4j/mojarra#5105 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants