Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models never saved if --no_earlystopping is used #1

Open
thvasilo opened this issue Jun 28, 2017 · 1 comment
Open

Models never saved if --no_earlystopping is used #1

thvasilo opened this issue Jun 28, 2017 · 1 comment

Comments

@thvasilo
Copy link

With the current code structure, evaluation and saving of the models only happens when the --no_earlystopping is not provided.

Ideally we would like some form of evaluation to happen even when not using LM (not sure if possible) and perhaps saving the models at the end of each epoch regardless of the arguments provided.

Since this should be a simple change, let me know if you are currently open to accepting PRs.

@jakezhaojb
Copy link
Owner

we are open to accepting PRs! Please do 👍
thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants