Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve crashing issue when toggling light/dark mode #1144

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

IgnacioPorte
Copy link

@IgnacioPorte IgnacioPorte commented Feb 27, 2025

Closes #1142

Description

The app crashes when the light/dark mode button toggles fast. A timeout to disable the button was added.

Steps to Test

  1. Open polar
  2. Click on any simnet instance
  3. Once running, spam click the light / dark mode toggle

Screenshots

.

@jamaljsr jamaljsr self-requested a review February 27, 2025 11:19
@jamaljsr
Copy link
Owner

The code seems fine. It looks like this breaks the unit tests. Can you please update the failing tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: App crashes when clicking Light / Dark mode toggle
2 participants