Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in next_message_reader #36

Open
Roman-Koshelev opened this issue Apr 2, 2021 · 2 comments
Open

Error in next_message_reader #36

Roman-Koshelev opened this issue Apr 2, 2021 · 2 comments

Comments

@Roman-Koshelev
Copy link

The line "8=FIX" will not necessarily be the beginning of a new message. For example, you will get "58=FIX arbitrary string". Search correctly for "\18=FIX"
@jamesdbrock
Copy link
Owner

Yeah, good point. That's a rare case but it could occur. That should be fixed. Do you want to make a PR?

@Roman-Koshelev
Copy link
Author

Yes, I will be happy to do PR. (a couple of hours and it's all in the bag)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamesdbrock @Roman-Koshelev