Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to convert it to a PWA #38

Open
shahadatksr opened this issue Jul 5, 2018 · 1 comment
Open

How to convert it to a PWA #38

shahadatksr opened this issue Jul 5, 2018 · 1 comment

Comments

@shahadatksr
Copy link

In the config.yml there is a service_worker : true line and a sw.js file in the root directory.This has to do something with PWA i guess So I want to know how to add a manifest.json file an convert it to a pwa.I also want to know how to enable offline functionality.Thanks.

@janczizikow
Copy link
Owner

Right now there's a service worker, but it's actually not configured properly. Need to consider following constrains:

  • When deploying to gh pages the roo pathname in url might be different (for personal/organization page: "/" and for project pages "/project-name".
  • Site might be build with bundler or gulp and service worker would have to work for both of those scenarios (when installed from ruby gems & when running the site with bundler or gulp).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants