Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epic: New Model Support SOP + Systems #20

Closed
2 of 4 tasks
dan-homebrew opened this issue Sep 26, 2024 · 2 comments
Closed
2 of 4 tasks

epic: New Model Support SOP + Systems #20

dan-homebrew opened this issue Sep 26, 2024 · 2 comments

Comments

@dan-homebrew
Copy link

dan-homebrew commented Sep 26, 2024

Goal

  • Support new models within 24 hours of release in Jan and Cortex

Process

  1. Create model conversion request ticket to Github board (janhq/jan or janhq/cortex.cpp) @gabrielle-ong

  2. Convert Model @gabrielle-ong

    1. New model is published by author - Instruct models only. See license
    2. debug & curate model.yml @nguyenhoangthuan99: stop tokens, max_tokens, ngl, ctx_len, prompt_template
    3. Create HF cortexso repo, model card, with correct descriptions, attribution, etc
    4. From author's repo, ungate access if needed (logged in with team HF account for CI)
    5. Use Model Converter to convert the model into GGUF, TRTLLM, and ONNX, and upload to HF
    6. Add model.yml (no default)
  3. QA (Cortex Team - @gabrielle-ong)
    6. Ensure it is downloadable and usable on Cortex
    8. Ensure it is downloadable and usable on Jan
    9. Debug if necessary

  4. Marketing @eckartal
    11. Craft a mini update to users

Systems

  • Repo janhq/models: Holds converter, and we hold "Model Inventory" there
    • Submodule?
  • Kanban board for type: model requests, imported from janhq/jan and janhq/cortex.cpp model requests
  • HF: huggingface.co/janhq (no more cortexso)

Tasklist

Out-of-scope

  • Jan Hub pulls from remote Model Hub

Related

@dan-homebrew dan-homebrew changed the title epic: SOP for new model support epic: New Model Support SOP + Ownership Sep 26, 2024
@dan-homebrew
Copy link
Author

dan-homebrew commented Sep 26, 2024

I think we need to a process to support this:

  • Repo: janhq/models (holds the converter scripts?)
  • Project Board with Model Status (with clear ownership of each Status + Process)

There are really two roles:

  • @eckartal to create ticket for new models
  • @hahuyhoang411 to do basic conversion and testing
  • Cortex team to step in only if it doesn't work directly out of the box

@dan-homebrew dan-homebrew changed the title epic: New Model Support SOP + Ownership epic: New Model Support SOP + Systems Sep 27, 2024
@dan-homebrew dan-homebrew transferred this issue from janhq/cortex.cpp Sep 29, 2024
@hahuyhoang411 hahuyhoang411 self-assigned this Oct 24, 2024
@gabrielle-ong
Copy link

@hahuyhoang411 thanks for taking this on and releasing the Models! Closing this issue

@github-project-automation github-project-automation bot moved this from In Review to Review + QA in Jan & Cortex Nov 11, 2024
@gabrielle-ong gabrielle-ong moved this from Review + QA to Completed in Jan & Cortex Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants