Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification Required for the Use of "if not is_last:" Condition #39

Open
Waybaba opened this issue Jul 12, 2023 · 0 comments
Open

Clarification Required for the Use of "if not is_last:" Condition #39

Waybaba opened this issue Jul 12, 2023 · 0 comments

Comments

@Waybaba
Copy link

Waybaba commented Jul 12, 2023

https://github.com/jannerm/diffuser/blob/7ea422860cc0106e5ca5949d980f04b799d5462c/diffuser/models/temporal.py#L89C4-L89C4

Dear Maintainers,

I was examining the line of code at this location: Link and came across the conditional statement if not is_last:. Given that each block halves the horizon, I'm wondering if this if statement is necessary.

When I attempted to integrate the code with maze2d, it appeared that the code runs only upon removal of this line. Could you provide some insight into its function and why it might be necessary in the current implementation?

I appreciate your guidance on this issue. Thank you.

Best Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant