Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about apply_conditioning with self.predict_epsilon during training #67

Open
OAHC2022 opened this issue Jul 18, 2024 · 0 comments

Comments

@OAHC2022
Copy link

Firstly, thank you for your amazing work!

I have a question regarding the code in diffusion.py (https://github.com/jannerm/diffuser/blob/main/diffuser/models/diffusion.py#L215). Specifically, when self.predict_epsilon is set to True, I understand that x_recon represents the predicted noise.

In this scenario, does applying apply_conditioning to x_recon still make sense? Additionally, if the cond is empty, it seems like the line

x_noisy = apply_conditioning(x_noisy, cond, self.action_dim)

at line 212(https://github.com/jannerm/diffuser/blob/main/diffuser/models/diffusion.py#L212) would have no effect. However, I assume this could still be useful to constrain the start condition during training?

Thank you for your time and consideration!

@OAHC2022 OAHC2022 changed the title Question about apply_conditioning with self.predict_epsilon in Diffuser Question about apply_conditioning with self.predict_epsilon during training Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant