feat: auto open generated html (fixes #10) #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
force-pushed
the
feat/auto-open
branch
from
2c717ff to
2daf59d
Compare
aladdin-add
changed the title
aladdin-add
changed the title
|
friendly ping @jantimon |
jantimon
reviewed
Mar 30, 2020
jantimon
reviewed
Mar 30, 2020
jantimon
reviewed
Mar 30, 2020
jantimon
reviewed
Mar 30, 2020
jantimon
reviewed
Mar 30, 2020
|
Hey @aladdin-add thanks a lot for your changes :) I have some questions - please let me know what you think |
aladdin-add
force-pushed
the
feat/auto-open
branch
from
9568de8 to
75c4d5e
Compare
|
Nice I'll try to take a look tonight 👍 |
it also fixes jantimon#7, by moving the function call to its constructor. :)
Co-Authored-By: Jan Nicklas <[email protected]>
aladdin-add
force-pushed
the
feat/auto-open
branch
from
75c4d5e to
8d12bf5
Compare
aladdin-add
force-pushed
the
feat/auto-open
branch
from
8d12bf5 to
9e4fc64
Compare
|
friendly ping @jantimon |
|
re-ping @jantimon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it also fixes #7, by moving the function call to its constructor. :)