Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for OpenAPI 3.1.0 specs #4

Closed
mrsafalpiya opened this issue Nov 4, 2024 · 4 comments
Closed

No support for OpenAPI 3.1.0 specs #4

mrsafalpiya opened this issue Nov 4, 2024 · 4 comments
Labels
Type: Enhancement Improving an existing feature

Comments

@mrsafalpiya
Copy link

Package version

3.0.0

Describe the bug

What

Currently the OpenAPI 3.1.0 specs is not supported.

Cause

@japa/assert 3.0.0 depends upon api-contract-validator ^2.2.8 which depends upon api-schema-builder ^2.0.10 which depends upon openapi-schema-validator ^3.0.3 (which is based on this commit from 2019-01-31: kogosoftwarellc/open-api@2781e85#diff-70c35980076f3148e728c8457dc8dc282a65872bbe4d51aec3a13282775e7fcdR7)

For context 3.1.0 spec was released in 2021-02-15.

Fix (Not viable)

Make api-schema-builder use openapi-schema-validator v12.1.3 fully supports OpenApi 3.1.0. This is not viable as both api-contract-validator and api-schema-builder seem to be abandoned.

Reproduction repo

No response

@thetutlage
Copy link
Contributor

I don't have the bandwidth right now to work on this issue. If anyone feels like opening a PR, feel free to do it :)

@thetutlage thetutlage added the Type: Enhancement Improving an existing feature label Nov 5, 2024
@mrsafalpiya
Copy link
Author

I found a temporary fix by using the overrides fields in package.json as:

  "overrides": {
    "api-schema-builder": {
      "openapi-schema-validator": "^12.1.3"
    }
  },

Maybe mention it in docs till a proper fix comes along? 🤷

@josevelaz
Copy link

This was also causing issues with npm ci within containerized environments
#3

@thetutlage
Copy link
Contributor

Fixed by #5

It will be moved to its own plugin. However, we still can't fix the transitive dependencies of that package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improving an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants