Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If callbackURL is relative, it becomes http:// url when it should be https:// #137

Open
1aerostorm opened this issue May 16, 2021 · 2 comments

Comments

@1aerostorm
Copy link

1aerostorm commented May 16, 2021

koa ^2.13.0
koa-passport latest
passport-facebook latest

Facebook can't authenticate because callbackURL becomes http://. But my request URL is https://.

Then I providing absolute callbackURL with https:// scheme, it working.

It is due to this check:
https://github.com/jaredhanson/passport-oauth2/blob/master/lib/utils.js#L27
req.connection.encrypted is very obsolete and not working, we should use req.secure for both Express and Koa.

@simonbergstrom
Copy link

  • 1 on this issue. Any workaround when using relative path? It would be really good to solve.

@mr-pinzhang
Copy link

facing the same issue here, I have to pass a new calculated URL with "https" when running passport.authenticate(..., { callbackURL: 'https://...' })

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants