Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sessionKey for SessionStateStore depends on OAuth hostname #94

Open
joh-klein opened this issue Oct 28, 2017 · 0 comments
Open

sessionKey for SessionStateStore depends on OAuth hostname #94

joh-klein opened this issue Oct 28, 2017 · 0 comments

Comments

@joh-klein
Copy link

I know, that's what the code says anyway.
Couple of questions: Why? :)
My Issue: since the key is session independent (by design) it is always generated by the last user, that is trying to log in. If the OAuth URL changes between users (which it does in my scenario) it is possible, that the key changes for a slow user (when another user tries to login before the first user is successfully logged in) and thus the state can't be validated.

Now, I know I can set the sessionKey to a fixed value, but I was wondering, why you are generating it from something, that can potentially change between users.

PS: All this insight was made possible by the PR #93 which finally explained all the different options! Thanks for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant