-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suspense! #175
Comments
@jaredpalmer at a high level, how do you envisage this affecting afterjs? What could be the benefits or problems? Here is an article on suspense and SSR: https://blogg.svt.se/svti/react-suspense-server-rendering/ |
single pass rendering. |
no need for after.js lol |
but seriously, there will still need to be some way to hydrate even with streaming. so after.js would handle that if React pushes some of that to user land. it's hard to say. |
Hola! So here's the deal, between open source and my day job and life and what not, I have a lot to manage, so I use a GitHub bot to automate a few things here and there. This particular GitHub bot is going to mark this as stale because it has not had recent activity for a while. It will be closed if no further activity occurs in a few days. Do not take this personally--seriously--this is a completely automated action. If this is a mistake, just make a comment, DM me, send a carrier pidgeon, or a smoke signal. |
"fizz" updates have been made to react enabling enable a better path for sssr facebook/react#14144 |
Man, so many things happening, hard to follow hahaha So, I am just researching a better way to migrate an application on React 16 + React Router 4 + Redux Sagas to a SSR solution. I was almost decided to go with After since Next.js is "too opinionated" for my taste and Electrode seems "too complicated" (I think of it like a war machine for my simples SSR for SEO needs... maybe I am mistaken, but the bootstrapped app seems already too complicated). Should I wait or try using alpha versions of React 17? I am divided right know between After and try React 17 by hand. @jaredpalmer It would be too hard to migrate an After based SSR app to the new approach introduced by React 17? |
@renatorroliveira check my comment here #133 (comment) As I see it essentially removes the need for getInitialProps which both next and Afterjs use. I'm very sure it will be simple to move logic out of getInitialProps and into a function called by suspense. Both return props so I'm confident it would be simple. |
It's hard to say for sure, but yes we could do what @krazyjakee described. However, the entire premise of |
@jaredpalmer unrelated question. In a post-getInitialProps world, where would a component receive the afterjs context to, for example, set the response status code? Edit: Related tweet https://twitter.com/jaredpalmer/status/1090261003655409664?s=19 |
Hola! So here's the deal, between open source and my day job and life and what not, I have a lot to manage, so I use a GitHub bot to automate a few things here and there. This particular GitHub bot is going to mark this as stale because it has not had recent activity for a while. It will be closed if no further activity occurs in a few days. Do not take this personally--seriously--this is a completely automated action. If this is a mistake, just make a comment, DM me, send a carrier pidgeon, or a smoke signal. |
Nooooo don't you dare. Palmdawg needs this issue. |
Hola! So here's the deal, between open source and my day job and life and what not, I have a lot to manage, so I use a GitHub bot to automate a few things here and there. This particular GitHub bot is going to mark this as stale because it has not had recent activity for a while. It will be closed if no further activity occurs in a few days. Do not take this personally--seriously--this is a completely automated action. If this is a mistake, just make a comment, DM me, send a carrier pidgeon, or a smoke signal. |
Closed due to inactivity. Holler if this is a mistake, and we'll re-open it. |
Just found react-lightyear, which exposes a |
@Ricki-BumbleDev got a minimal project we can look at? |
@Ricki-BumbleDev Glad you found it useful! 😄 @krazyjakee There are also a couple of examples in the repo itself, for using with Redux, Apollo (using the unofficial react-apollo-hooks) or urql. Checking out After.js has been on my list for a while but I haven't gotten around to it. After finding this issue I skimmed the Custom/Async Rendering-part of the documentation and there should be no problem just switching out the Whether it actually makes sense to use After.js for this instead of just using Razzle directly (which I do in the examples) I couldn't say. 😄 |
Opening up discussion for what Suspense-based API will look like.
The text was updated successfully, but these errors were encountered: