Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note 20 Ultra #43

Open
ytheekshana opened this issue Aug 30, 2020 · 5 comments
Open

Note 20 Ultra #43

ytheekshana opened this issue Aug 30, 2020 · 5 comments

Comments

@ytheekshana
Copy link

ytheekshana commented Aug 30, 2020

My device is a Note 20 Ultra. But it shows as c2s.

image

Is there a fix for this.?

@RUSSCITY
Copy link

RUSSCITY commented Jan 8, 2021

@jaredsburrows @jaredrummler could you please update the DB? I'm missing as well some of the models, e.g. all Samsung Note20.
Or maybe you have an instruction on how to manually update the DB from https://storage.googleapis.com/play_public/supported_devices.html?

@XiXiongMaoXiong
Copy link

XiXiongMaoXiong commented Jan 10, 2021

@jaredsburrows @jaredrummler could you please update the DB? I'm missing as well some of the models, e.g. all Samsung Note20.
Or maybe you have an instruction on how to manually update the DB from https://storage.googleapis.com/play_public/supported_devices.html?

@RUSSCITY
My forked version has the latest database update as of January 2021, and has over 30 thousand devices. You can import it from here:

https://github.com/NotNotMarshall/AndroidDeviceNames

@jaredsburrows
Copy link
Contributor

@NotNotMarshall If you did the work on a separate fork, why not merge it back into this repository? Make a pull request?

@XiXiongMaoXiong
Copy link

@NotNotMarshall If you did the work on a separate fork, why not merge it back into this repository? Make a pull request?

@jaredsburrows
It's not allowed mate, you have disabled the ability to upload files into your repo. So I can merge everything but when it comes to uploading the new database I just can't.
That was the reason that made me fork the repo otherwise I'd be more than happy to contribute to this library.

@tdtran
Copy link

tdtran commented Jan 13, 2021

@NotNotMarshall do you know what a pull request is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants