Bug fix Display name and manufacter name #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goransipic
changed the title
|
There is bug for displaying name for Samsung Galaxy S21 Ultra 5G is already fixed by #45. Its seems this is general problem for other phones not only for Samsung phone. |
|
@goransipic We are experiencing this issue too: A Samsung S21 is wrongly getting identified as a TECNO P3S by the library, and checking the database, it seems they share the same codename @jaredrummler any chance we could prioritise merging this fix? And thank you for giving us this awesome library! 🙏 |
…ent-accessing-error
|
Google pixel 7 pro is facing this same issue. |
|
@jaredrummler Do you have any plans to merge this PR or update the database? Thanks |
sam5569
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is bug for displaying name for Samsung Galaxy S21 Ultra 5G.
If manufacture field is missing lib always connect to database.