Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with search and pagination when using group by #27

Open
ghost opened this issue May 24, 2020 · 1 comment
Open

Error with search and pagination when using group by #27

ghost opened this issue May 24, 2020 · 1 comment

Comments

@ghost
Copy link

ghost commented May 24, 2020

Recent change introduced in Laravel 7.10.0, and merged from laravel/framework#32624 broke search and pagination functionality when Eloquence is used with group by queries.

Problem with both is that base version of runPaginationCountQuery is changed, and now uses subquery to get count for pagination. This produces multiple rows of aggregates, and the pagination total is returned from first row only.

This can be solved by replacing/removing the method in Sofa\Eloquence\Query\Builder, but then search query gets wrapped in subquery and times out for me, so I couldn't get any further in investigating it.

@C10ne
Copy link

C10ne commented Aug 27, 2020

Any info when Laravel 7.10.+ version will be supported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant