Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Feature request: a error block inplace code like LightTable #146

Open
comerc opened this issue Aug 16, 2016 · 5 comments
Open

Feature request: a error block inplace code like LightTable #146

comerc opened this issue Aug 16, 2016 · 5 comments

Comments

@comerc
Copy link

comerc commented Aug 16, 2016

2016-08-16 11 57 46

@jasongilman
Copy link
Owner

@carocad I bet this could be included as part of the exception improvements.

@comerc
Copy link
Author

comerc commented Aug 16, 2016

I love Atom, but it is a key feature for me. :)

@carocad
Copy link
Contributor

carocad commented Aug 16, 2016

@jasongilman @comerc I'm sorry to say it but I'm not planning to support inline exceptions in this way.

I tried before to improve those messages but it always lead to problems as you have to "marry" the stacktrace library that outputs those messages, and the users cannot choose afterwards if they wanted that one or not. For lighttable that was clj-stacktrace, which is quite good to be honest but it is still a personal choice. You can check the whole discussion here

@comerc What I can promise you is that if everything goes as planned, then the exceptions would be even more powerful than those of LT. You can follow the progress here. We are planing to integrate this but without the inline part.

I hope you will like it ;)

@carocad
Copy link
Contributor

carocad commented Aug 17, 2016

@comerc I actually changed my mind after thinking about some of the features that I wanted to support. Here is a screenshot of the current progress for inline exceptions :D
captura de pantalla de 2016-08-17 14-49-09

Those will be different to LT ones though. They will only appear on user request; by calling pst or something similar.

There is still much to be done but your feedback is much appreciated

@carocad
Copy link
Contributor

carocad commented Sep 1, 2016

@comerc I have implemented some even cooler features for inline exceptions such as line highlighting and hyperlinks to the error files.

I have a PR here: #160

I would appreciate if you could fork and test it so that we can be sure that everything works as it should.

Just as a teaser, here is a screenshot
captura de pantalla de 2016-08-29 12-05-47

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants