Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve source module to have more robust text parsing #17

Open
jasonrichardsmith opened this issue Aug 30, 2018 · 2 comments
Open

Improve source module to have more robust text parsing #17

jasonrichardsmith opened this issue Aug 30, 2018 · 2 comments

Comments

@jasonrichardsmith
Copy link
Owner

Do you wish to add functionality to an existing sentry module?
Make more robust options for text matching strategies for source module.

@towolf
Copy link

towolf commented Sep 9, 2018

We wrote this plugin for Docker itself, before ValidatingWebhooks were a thing.

We simply went with regex blacklists and whitelists, and an example config looks like this:

{
  "whitelist": [
    "^alpine:",
    "^docker\\.elastic\\.co/beats/filebeat:",
    "^gcr\\.io/google_containers",
    "^mysql:",
    "^nginx:",
    "^php:",
    "^apache:",
    "^quay\\.io/calico/cni",
    "^quay\\.io/calico/node",
    "^quay\\.io/coreos/flannel"
  ],
  "blacklist": [
    "^docker:"
  ],
  "defaultAllow": false
}

Anybody in this space can deal with regex and it is powerful enough.

@jasonrichardsmith
Copy link
Owner Author

@towolf thanks for your input, I am still weighing the options. Your solution is probably the strongest contender.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants