Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single Classification wrapper function #24

Open
jatkinson1000 opened this issue Mar 18, 2023 · 2 comments
Open

Single Classification wrapper function #24

jatkinson1000 opened this issue Mar 18, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@jatkinson1000
Copy link
Owner

Currently classifications are called depending on the type of classification required.

Consider a single generic wrapper function that can be called that then recursively calls the existing functions.
@jatkinson1000 jatkinson1000 added the enhancement New feature or request label Mar 18, 2023
@jatkinson1000
Copy link
Owner Author

All the pylint errors in #25 are hinting that the classifications code smells a bit.
Addressing this with a refactor might help towards reducing some of the pylint issues.

This was referenced Mar 21, 2023
Merged
Closed
@jatkinson1000 jatkinson1000 mentioned this issue Aug 20, 2023
Merged
1 task
@TomHall2020
Copy link
Contributor

Think this can probably be closed now, #42 was implemented a while ago and things have been restructured much more since via #78

@TomHall2020 TomHall2020 mentioned this issue Dec 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TomHall2020 @jatkinson1000