fix: reapplying conditions no longer removes them #298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functions addCondition and removeCondition to creature.ts to allow for better handling of conditions. Add remove_status field to CreatureUpdate, which is used to call creature.removeCondition. Add remove_status to logger.types.ts and move logging of condition removal to the logger
Pull Request Description
Change behaviour upon reapplying a condition to not change the state of the tracker if the conditions are considered equal.
Note that comparisons on IDs is specifically not done in order to avoid problems with improvised conditions.
Changes Proposed
Related Issues
Fixes #297
Checklist
Additional Notes
I haven't run my linter as my and Javelent's settings are different and cause massive merge conflicts, but I've taken care to style the changes properly.