Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Performance impact on dataview #30

Open
2 of 7 tasks
ItsFullOfCode opened this issue Sep 16, 2023 · 1 comment
Open
2 of 7 tasks

🐞 Performance impact on dataview #30

ItsFullOfCode opened this issue Sep 16, 2023 · 1 comment

Comments

@ItsFullOfCode
Copy link

Check for existing bug reports before submitting.

  • I searched for existing Bug Reports and found no similar reports.

Expected Behavior

markdown-attributres plugin should not have side effects on dataview's rendering performance.

Current behaviour

Rendering any dataview table with dv.view() had recently become quite slow on my Obsidian Windows installation. A couple of tables with slightly over 70 results took over 30 seconds to load.

The Performance profile indicated that the recent dataview performance hit might be related to the installation of the Markdown Attributes plugin. Once I disabled this plugin, dataview rendering became again near instantenous. Below a screenshot of the performance profile.

gnAU6Hktlk

Reproduction

  • Install javalent plugin
  • Install dataview plugin
  • Create a dataview query using dv.view() that will result in loading a significant number (+50) of records with a few data columns
  • Execute the query
  • Observer the table rendering performance with the markdown-attirubes plugin disabled
  • Observer the table rendering performance with the markdown-attirubes plugin enabled

Which Operating Systems are you using?

  • Android
  • iPhone/iPad
  • Linux
  • macOS
  • Windows

Obsidian Version Check

1.4.13, 1.4.13

Plugin Version

1.2.2

Confirmation

  • I have disabled all other plugins and the issue still persists.

Possible solution

No response

@EvanEdwards
Copy link

I can confirm this. Tasks (which uses Dataview) has a similar slowdown. There's some kind of interaction that appears to be causing the issue. I have not dug in (for reasons stated below).

I am commenting to both confirm this bug and to point out that Dataview is nearing the end of a complete rewrite and rearchitecture that may address the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants