Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property flags and descriptors #219

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

herbertpdl
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jul 25, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@odsantos odsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @herbertpdl,

Here is a review.
Please, feel free to comment where you disagree.

Thank you.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@herbertpdl
Copy link
Author

@odsantos Done!

@odsantos
Copy link
Contributor

Hi @herbertpdl , the repository was updated and this branch has conflicts, so it also needs to be updated.
If you have time to do it, could you please comment in the end here as \done only?
It is the way the bot tracks the changes and alters from changes requested to pending review.
Thank you.

@herbertpdl
Copy link
Author

/done

Copy link
Contributor

@odsantos odsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @herbertpdl,

Here is another review.

Thank you.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@herbertpdl
Copy link
Author

/done

@odsantos
Copy link
Contributor

Hi @herbertpdl ,

Still working on this one.
There is conflict here.
If resolved I could try another review.

Thanks,
Osvaldo.

@nazarepiedady
Copy link
Member

@Peruibeloko, @jonnathan-ls, do you have time to see what is possible to do in relation to this pull request?

@Peruibeloko
Copy link
Contributor

@nazarepiedady his master branch is write protected, but I resolved all the conflicts here: https://github.com/Peruibeloko/pt.javascript.info/tree/herbertpdl/master

@nazarepiedady
Copy link
Member

@Peruibeloko, could you copy his work, review it, and create your own pull request to solve this issue?

@Peruibeloko
Copy link
Contributor

@nazarepiedady will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants