Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline mode of anchors ^ $, flag "m" #421

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Peruibeloko
Copy link
Contributor

No description provided.

Copy link
Member

@nazarepiedady nazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Peruibeloko, could you evaluate the review I did?

9-regular-expressions/05-regexp-multiline-mode/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@Peruibeloko
Copy link
Contributor Author

/done

Copy link
Member

@nazarepiedady nazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is ready to be applied.

@nazarepiedady
Copy link
Member

@danilolmc, @jonnathan-ls, could you help to review this pull request and approve it if it is okay?

Copy link
Contributor

@danilolmc danilolmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Droped just a single comment, not a big deal!

The PR LGTM!

@Peruibeloko
Copy link
Contributor Author

@nazarepiedady Implemented the change, we're able to merge now!

@nazarepiedady
Copy link
Member

@Peruibeloko, I need one person to approve the updates, this person does not need necessarily to be a maintainer, a regular contributor serves.

@nazarepiedady
Copy link
Member

@danilolmc, do you have time to approve these updates?

@nazarepiedady
Copy link
Member

@jonnathan-ls, could you approve these updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants