Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish intrusions #35

Open
lynxlynxlynx opened this issue Nov 9, 2021 · 2 comments
Open

Spanish intrusions #35

lynxlynxlynx opened this issue Nov 9, 2021 · 2 comments

Comments

@lynxlynxlynx
Copy link

Not sure if it will be fixed with #17, but currently this page displays some extraneous Spanish copies of principles:
https://principles.green/principles/carbon/ (2 extra)

Considering how it's generated (https://github.com/jawache/principles-green/blob/master/src/_includes/partials/components/principle-list.njk), the files just miss language: es keys in their front matter.

I can submit a PR if that's desired. It might be more error-proof to retire the keys and derive them from the file path, but that's probably more carbon intensive. ;)

@ivantxu
Copy link
Contributor

ivantxu commented Dec 4, 2021

This has been fixed in the PR I've opened, this should properly add both the translations and the navigation link to Spanish, you can check the changes in #36

@Willmish
Copy link

Resurfacing this, as I recently just stumbled upon this error myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants