Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Python 3.12 #221

Closed
amotl opened this issue Sep 29, 2023 · 7 comments
Closed

Compatibility with Python 3.12 #221

amotl opened this issue Sep 29, 2023 · 7 comments

Comments

@amotl
Copy link
Contributor

amotl commented Sep 29, 2023

Hi there,

thank you very much for conceiving and maintaining the geojson package.

We are currently evaluating support for Python 3.12 on behalf of earthobservations/wetterdienst#1008, and wanted to report an observation we just made over there 12:

SolverProblemError

The current project's Python requirement (3.12.0rc3) is not compatible with some of the required packages Python requirement:
- geojson requires Python >=3.7, <3.12, so it will not be satisfied for Python 3.12.0rc3

Because geojson (3.0.1) requires Python >=3.7, <3.12
and no versions of geojson match >=3,<3.0.1 || >3.0.1,<4, geojson is forbidden.
So, because wetterdienst depends on geojson (>=3,<4), version solving failed.

Python 3.12 will be released on 2023-10-02 3, so, if nothing speaks against it, it might be applicable to relax the version constraint, and run another release in order to unlock a few other applications depending on geojson?

With kind regards,
Andreas.

Footnotes

  1. https://github.com/earthobservations/wetterdienst/actions/runs/6357687659/job/17269167025?pr=1008#step:6:46

  2. https://github.com/earthobservations/wetterdienst/actions/runs/6397097015/job/17364294300?pr=1008#step:6:51

  3. https://devguide.python.org/versions/

@hugovk
Copy link
Member

hugovk commented Oct 3, 2023

This restriction was relaxed to 3.7 - 3.12 in #215 (although I don't think there should be any upper bound).

What is missing is a release to PyPI.

@rayrrr After #222 is merged, please could you make a new release?

@amotl
Copy link
Contributor Author

amotl commented Oct 9, 2023

Hi again,

thank you for integrating GH-222 so quickly, @hugovk.

The package can now be installed well interactively, as a workaround, by invoking pip install git+https://github.com/jazzband/geojson, but it can't be used as a dependency in setup.py / setup.cfg / pyproject.toml, unless it will be released on PyPI, right?

So, in order to support the advent of Python 3.12, can we humbly ask you to run a release on PyPI?

With kind regards,
Andreas.

@hugovk
Copy link
Member

hugovk commented Oct 9, 2023

Yes, it's possible.

Here's an example: https://peps.python.org/pep-0508/#examples

For example in pyproject.toml:

dependencies = [
  "geojson @ https://github.com/jazzband/geojson/archive/refs/heads/main.zip",
]

Note this installs from a zip which should be quicker than from a Git clone.

@cpontvieux-systra
Copy link

What’s blocking to make a proper Pypi release?

@rayrrr
Copy link
Member

rayrrr commented Nov 1, 2023

New release forthcoming. I just need to write up the changelog and push it out. Will aim to get it done by this weekend at the latest.

@rayrrr
Copy link
Member

rayrrr commented Nov 5, 2023

3.1.0 has been released with Python 3.12 support. https://pypi.org/project/geojson/

@rayrrr rayrrr closed this as completed Nov 5, 2023
@amotl
Copy link
Contributor Author

amotl commented Nov 6, 2023

Dear Ray,

thank you so much for running a release ❤️. On two downstream projects, we've invoked corresponding CI runs. It seems to work well 1.

With kind regards,
Andreas.

Footnotes

  1. Modulo Wetterdienst, now failing on h5py, but that's a different thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants