Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel Central Registry release #1229

Closed
stonier opened this issue Sep 18, 2023 · 3 comments
Closed

Bazel Central Registry release #1229

stonier opened this issue Sep 18, 2023 · 3 comments

Comments

@stonier
Copy link
Contributor

stonier commented Sep 18, 2023

Related to #1224.

@jbeder would you be able to add the 0.8.0 source tarball as an asset to the 0.8.0 release?

Example: https://github.com/stonier/yaml-cpp/releases/tag/0.8.0-1

Rationale: Pointing at the source tarball url's attached to a release is apparently unstable.

You should use a release archive URL in the format of `https://github.com/<ORGANIZATION>/<REPO>/releases/download/<version>/<name>.tar.gz` to ensure the archive checksum stability.
See https://blog.bazel.build/2023/02/15/github-archive-checksum.html for more context.

If that's there, I can apply the changes I made in #1224 as bazel module patches. Future releases won't need those patches.

Alternatively I can simply release from https://github.com/stonier/yaml-cpp/releases/tag/0.8.0-1 until the next yaml-cpp release arrives.

@zaucy
Copy link
Contributor

zaucy commented Oct 1, 2023

I created a PR to automatically create the archive on release for future versions #1230. A manual archive for 0.8.0 would still be required :)

@stonier
Copy link
Contributor Author

stonier commented Dec 23, 2023

I created a PR to automatically create the archive on release for future versions #1230. A manual archive for 0.8.0 would still be required :)

That's nice ... I'd not gotten around to working out how to do that, now I don't have to - thanks!

@stonier
Copy link
Contributor Author

stonier commented Dec 23, 2023

@jbeder would you be able to add the 0.8.0 source tarball as an asset to the 0.8.0 release?

@jbeder if you can get around to this that'd be great, otherwise we'll switch across to it in future releases.

@stonier stonier closed this as completed Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants