You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, a network failure during remote logout (as part of SLO) will be silently ignored by mama_cas. It seems crucial that a logout failure is raised or at least returned so that the user can take appropriate action, like retry or refuse to logout.
Specifically, ServiceTicket.request_sign_out will blindly session.post without looking at the response.
logger.info("Single sign-out request sent to %s"%url)
This should probably raise on at least some very severe network errors, like timeouts or internal server errors.
I'm not sure how this plays with the requests-futures support, but it seems like mama_cas should at least expose a way to do this if you really want to.
The text was updated successfully, but these errors were encountered:
beheh
changed the title
Remote signout should raise on request failure
Single logout should raise on request failure
Jul 8, 2019
Right now, a network failure during remote logout (as part of SLO) will be silently ignored by mama_cas. It seems crucial that a logout failure is raised or at least returned so that the user can take appropriate action, like retry or refuse to logout.
Specifically,
ServiceTicket.request_sign_out
will blindlysession.post
without looking at the response.django-mama-cas/mama_cas/models.py
Lines 248 to 257 in 03935d9
This should probably raise on at least some very severe network errors, like timeouts or internal server errors.
I'm not sure how this plays with the requests-futures support, but it seems like
mama_cas
should at least expose a way to do this if you really want to.The text was updated successfully, but these errors were encountered: