From a6c8a2f07f0fa5cae6a726c96dcb1e022f417c01 Mon Sep 17 00:00:00 2001 From: wokis Date: Mon, 8 Nov 2021 20:03:40 +0100 Subject: [PATCH] InfoAdditionalInformation should be of type flags and not enum fixes #152 (#153) --- CHANGELOG.md | 5 +++++ smbprotocol/open.py | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8872cd58..cf7b950e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,10 @@ # Changelog +## 1.8.3 - TBD + +* Set `additional_information` field in `SMB2SetInfoRequest` to a flags field rather than a single enum as per protocol docs + + ## 1.8.2 - 2021-11-03 * Add missing `FileAttributes` enum values diff --git a/smbprotocol/open.py b/smbprotocol/open.py index f4571efe..afe1d551 100644 --- a/smbprotocol/open.py +++ b/smbprotocol/open.py @@ -1037,9 +1037,9 @@ def __init__(self): default=96 )), ('reserved', IntField(size=2)), - ('additional_information', EnumField( + ('additional_information', FlagField( size=4, - enum_type=InfoAdditionalInformation, + flag_type=InfoAdditionalInformation, )), ('file_id', BytesField(size=16)), ('buffer', BytesField(