Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hash-db-error-fix #407

Merged
merged 3 commits into from
Jan 5, 2025
Merged

hash-db-error-fix #407

merged 3 commits into from
Jan 5, 2025

Conversation

bpawnzZ
Copy link
Contributor

@bpawnzZ bpawnzZ commented Dec 26, 2024

fixes the error regarding missing hash database that occurs when tryinng to run after initial install. tested this on multiple machines and this is working

@NTFSvolume NTFSvolume self-assigned this Dec 26, 2024
@NTFSvolume NTFSvolume self-requested a review December 26, 2024 19:26
Copy link
Collaborator

@NTFSvolume NTFSvolume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

This does seem to solve the startup issue. Ideally, the database should have a hash table at this point in the process, but there seems to be an issue further up the logic chain. For now, though, this fix looks good to me.

Please remove the workflow for publishing an npm package since it doesn't apply to this repo. Additionally, format the code with ruff according to the contribution guidelines. All PRs must pass the ruff check.

Once updated, it’ll be ready to merge.. Thanks for your contribution!

.github/workflows/publish.yml Outdated Show resolved Hide resolved
@NTFSvolume NTFSvolume added the bug Something isn't working label Dec 27, 2024
@datawhores
Copy link
Collaborator

Hi,

This does seem to solve the startup issue. Ideally, the database should have a hash table at this point in the process, but there seems to be an issue further up the logic chain. For now, though, this fix looks good to me.

Please remove the workflow for publishing an npm package since it doesn't apply to this repo. Additionally, format the code with ruff according to the contribution guidelines. All PRs must pass the ruff check.

Once updated, it’ll be ready to merge.. Thanks for your contribution!

That was part of what I was trying to fix yesterday

It a little confusing because we have async startup and startup

But if you moved the transfer_hash function to after the db is started in async_startup it should work

@NTFSvolume
Copy link
Collaborator

Hi @bpawnzZ! Just checking in on this PR. Are you able to address the remaining feedback or provide an update?

The next version of CDL is ready for release and it will be ideal to include this fix as well. If you need help with something or additional information, let me know

@bpawnzZ
Copy link
Contributor Author

bpawnzZ commented Jan 3, 2025

I just realized this wasn't complete. I will handle as soon as I get home

@datawhores datawhores self-requested a review January 5, 2025 19:51
@datawhores datawhores merged commit a3dbdcf into jbsparrow:master Jan 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 'sqlite3.OperationalError: no such table: hash' error when starting
3 participants