Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify relation to setuptools #27

Open
akhmerov opened this issue Nov 2, 2020 · 2 comments
Open

Clarify relation to setuptools #27

akhmerov opened this issue Nov 2, 2020 · 2 comments

Comments

@akhmerov
Copy link

akhmerov commented Nov 2, 2020

Miniver imports setuptools, and therefore may fail in some environments. Is this intentional? Should packages using miniver have setuptools as a requirement?

@jbweston
Copy link
Owner

Hi Anton,

The only reason setuptools is used is because this is the Python packaging stack that I am most familiar with.
I was under the impression that the major Python distributions all ship with setuptools (even if it is not part of the standard library); could you elaborate on what environments you had in mind?

My understanding of newer technologies like Poetry is that they make extensive use of pyproject.toml to specify version metadata. I am not sure how this would interact with the need to dynamically obtain the version info from git.

@akhmerov
Copy link
Author

Hey Joe, thanks for the explanation!

I rather meant this as a point for miniver users, and as as a suggestion to write in the README what the users need to specify for the package to be miniver-compatible.

Regarding your last remark, there's seemingly https://pypi.org/project/poetry-dynamic-versioning/ (despite what the readme says, poetry will support plugins in the next version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants