Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle all errors properly #1

Open
8 tasks
jcxldn opened this issue May 24, 2019 · 0 comments
Open
8 tasks

Handle all errors properly #1

jcxldn opened this issue May 24, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@jcxldn
Copy link
Owner

jcxldn commented May 24, 2019

First of all, errors are not handled at all in some routes such as userstats and profile settings, and when errors are handled, only a few errors (namely 401 and 400) return a response code and message instead of empty data.

To-Do

  • Handle errors in all routes
    • Add to existing routes
    • UserStats
    • ProfileSettings
    • TitleStats
    • LegacySearch
  • Return error messages when appropriate
  • Return the correct response code instead of empty data
  • If an unexpected response code is recieved, do not return 200 and a blank message.
@jcxldn jcxldn self-assigned this May 24, 2019
@jcxldn jcxldn added the bug Something isn't working label May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant