-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SetRecordDirectoryAsync
throws FailureResponseException
"UnknownRequestType: Your request type is not valid."
#2
Comments
Oh, this seems to have been an oversight by the obs-websocket maintainers, this was fixed in 5.3.0 but the mainline OBS is currently using 5.2.3. The recommended workaround is to use SetProfileParameter for now. Now that I look closely, the method's comment does have info about the version it works in, but I was expecting it to work by default considering I have everything up to date and all, or at the very least a different exception. |
See 0.13.0 changelog. Do you want me to add something like |
I'd like to see a popup of the release notes when you install/update the library, I had no idea there was one as it wasn't anywhere in the nuget.org page or the readme. I suppose the issue remains until 5.3.0 releases to the main OBS, but this can be closed. |
I admit changelog is not enough and someone ever notice that we can't use this method neither. It would be nice if I can describe that method is experimental more prominently but there's no proper feature in doc comments. Currently I'm considering providing workaround implementation (though I'm not sure this is right) with the old obs websocket. |
What is the current status on this? I saw someone on claimed that it got fixed Link to the websocket setrecorddirectory doc They mentioned that 5.3.0 is released to the main OBS in OBS30 |
I didn't amend implementation, so if an user use OBS 30 or above Do you think this issue should be closed? |
Yes, I just tested my own Repro project after updating obs and the method works just fine. |
OBS version:
29.1.3
Library version:
0.14.0
OBS Websocket version:
5.2.3
RPC Version1
Log: 2023-09-11 16-38-55.txt
Repro project: ObsRepro.zip
I can't use ObsClientSocket.SetRecordDirectoryAsync to set the OBS recording folder, it throws a FailureResponseException as if the command was not recognized.
The text was updated successfully, but these errors were encountered: