Amend get_next #51
Open
Amend get_next #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amend the get_next function which calls /Shows/NextUp to include an optional seriesid and userid parameter
|
Did you have any feedback on this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amend the get_next function which calls /Shows/NextUp to include an optional seriesid and userid parameter.
This will allow you to retrieve the next up just for a specific series rather than all series, as well as getting the next up for a specific user rather than being limited to the user currently logged in.
Before I go down a rabbit hole with this as I have more changes I'd like to make. What's your opinion about allowing the user to specify a userid in the request rather than always using the current logged in user? I feel as an admin user logged in I should be able to retrieve information about any user rather than just the user I am logged in as. If you can already do this and I've missed it then let me know.