Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images are only sent as links and don't show up on Discord #243

Open
AllegraCodes opened this issue May 19, 2024 · 2 comments · May be fixed by #247
Open

Images are only sent as links and don't show up on Discord #243

AllegraCodes opened this issue May 19, 2024 · 2 comments · May be fixed by #247
Labels
feature This PR or Issue requests or introduces a new feature

Comments

@AllegraCodes
Copy link

Discord and other destinations are typically outside our local network, so references to images on our servers as shown in the templates can't resolve unless your server is accessible from the public web.

It would be fantastic if we could choose to upload the image files along with the message so thumbnails etc are visible in the message. This is allowed on discord webhooks but does require a more complicated http request.

@crobibero crobibero added the feature This PR or Issue requests or introduces a new feature label May 19, 2024
@AllegraCodes
Copy link
Author

I made a proof-of-concept/stopgap-solution using spring and jackson that may be helpful to whoever may implement this

https://github.com/AllegraCodes/jellyfin-discord-webhook-interceptor

@AllegraCodes AllegraCodes linked a pull request May 21, 2024 that will close this issue
@kristianvld
Copy link

I would also very much appreciate this feature. It would be nice to have this support all the places where an image can be added, not just the thumbnail as proposed in the pull request, such as the author.icon_url, footer.icon_url, image.url and thumbnail.url.

Perhaps the best thing would be to add another helper function in handlebars, which when called would download the image and add it as an attachment and return the attachment URL to be added to the field in question. This would also need to handle the attachments list somehow. Either that or that the plugin detects which images are local to Jellyfin and which might be external and perhaps images that you do not want to download and upload as attachments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This PR or Issue requests or introduces a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants