Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TV Support for 'Ask to Skip' #6295

Open
wants to merge 4 commits into
base: release-10.10.z
Choose a base branch
from

Conversation

viown
Copy link
Member

@viown viown commented Nov 4, 2024

Changes
Enables TV Support for the skip button

Issues

@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Nov 4, 2024

Cloudflare Pages deployment

Latest commit 6113edb
Status ✅ Deployed!
Preview URL https://e59dbfa3.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

@viown viown marked this pull request as ready for review November 6, 2024 17:28
@viown viown requested a review from a team as a code owner November 6, 2024 17:28
@viown viown added the needs testing This PR requires additional testing label Nov 6, 2024
@dmitrylyzo
Copy link
Contributor

dmitrylyzo commented Nov 11, 2024

  1. I think we should focus the skip button (on show) if OSD is hidden.
  2. Found bug: _skipElement is not reattached on the second video playback. Separate PR.
    1. Start video playback.
    2. Wait for the Skip button to appear.
    3. Stop playback (return to the library/item).
    4. Resume video playback. Button is not attached to the DOM.
  3. We should use emby-button to highlight the focus state. There is no (native) focus indication in webOS 1.2.

@viown
Copy link
Member Author

viown commented Nov 11, 2024

I think we should focus the skip button (on show) if OSD is hidden.

I agree, it's not intuitive to have to click up two times when the button appears.

Found bug: _skipElement is not reattached on the second video playback. Separate PR.

Thanks! This is an issue with just this PR because videoOsdPage is unmounted when playback stops and it originally only created the button once in the body and re-used it on second playback.

Copy link

sonarcloud bot commented Nov 18, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs testing This PR requires additional testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants