Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add media type specific translation in up next dialog #6307

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bluemoehre
Copy link
Contributor

Fixed a problematic change from #5666 that led to strange translations in some languages.

Changes
Add separate translations for media types in up-next dialog, since in some languages nouns like “video” and “episode” are gendered differently.

Issues

#6270

@bluemoehre bluemoehre requested a review from a team as a code owner November 8, 2024 17:59
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Nov 8, 2024

Cloudflare Pages deployment

Latest commit a50dd30
Status ✅ Deployed!
Preview URL https://18f2df9c.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

src/components/upnextdialog/upnextdialog.js Outdated Show resolved Hide resolved
src/components/upnextdialog/upnextdialog.js Outdated Show resolved Hide resolved
src/components/upnextdialog/upnextdialog.js Outdated Show resolved Hide resolved
src/components/upnextdialog/upnextdialog.js Outdated Show resolved Hide resolved
@bluemoehre bluemoehre force-pushed the fix-next-dialog-translation-issue branch from 97f8d76 to a50dd30 Compare November 10, 2024 16:58
Copy link

sonarcloud bot commented Nov 10, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants