Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jenkins Infra Docker Images: build our own Windows images #2873

Closed
7 tasks done
dduportal opened this issue Apr 7, 2022 · 3 comments
Closed
7 tasks done

Jenkins Infra Docker Images: build our own Windows images #2873

dduportal opened this issue Apr 7, 2022 · 3 comments
Assignees
@lemeurherve
Labels
ci.jenkins.io docker infra.ci.jenkins.io release.ci.jenkins.io site:ci.jenkins.io trusted.ci.jenkins.io windows
Milestone
infra-team-sync-2...

Comments

@dduportal
Copy link
Contributor

dduportal commented Apr 7, 2022 •
edited by lemeurherve
Loading

As for today, the Windows Docker images used by Jenkins agents on the Jenkins infrastructure are based on the jenkinsci/ images:

Using community image is nice but blocks (or at least slows) us when we need to add new features or custom settings that could impact the Jenkins CI usual users (but not OUR users):

We need to build and maintain our own Windows Docker images on infra.ci (hosted on DockerHub under the jenkinsciinfra organization) like we are already doing with the Linux Docker images in https://github.com/jenkins-infra/docker-inbound-agents/ .
It's totally posible since #13 was implemented \o/

TODO list:
@dduportal dduportal added this to the infra-team-sync-next milestone Apr 7, 2022
This was referenced Apr 7, 2022
Closed
Closed
@dduportal dduportal added this to the infra-team-sync-2022-05-24 milestone May 17, 2022
@lemeurherve lemeurherve mentioned this issue May 19, 2022
Merged
@github-actions github-actions bot added the triage Incoming issues that need review label May 24, 2022
dduportal pushed a commit to jenkins-infra/docker-inbound-agents that referenced this issue May 24, 2022
@lemeurherve
feat: Windows images (#21)
fa87a21 
* feat: add Windows images (wip)

Ref: jenkins-infra/helpdesk#2873

* debug: only interesting images

* debug: pr lib

* no container, we want a VM to build windows docker images

* Update maven/jdk8/Dockerfile.nanoserver

* Update Jenkinsfile_k8s

* Update Jenkinsfile_k8s

* Update Jenkinsfile_k8s

* deprecated mainBranch arg

* Update Jenkinsfile_k8s

* add platform pipeline arg

* add cst test & image

* fix: global pipeline lib

* fix new pr

* slash in Windows paths for container-structure-test

* fix paths

* fix paths

* Update common-cst-windows.yml

* feat: add all images

* no pwd test on windows

* align entrypoint of Windows Server Core image ("pwsh.exe" VS "powershell.exe")

* fix entrypoint
@lemeurherve
Copy link
Member

Add the git custom setup (if not already present on parent image) from #2847

Already included in the jenkins/docker-agent base image.

lemeurherve pushed a commit to lemeurherve/kubernetes-management that referenced this issue May 25, 2022
@lemeurherveCB
feat: use Jenkins Infra inbound-agent Windows Docker image
0644f5e 
Ref: jenkins-infra/helpdesk#2873
@lemeurherve lemeurherve mentioned this issue May 25, 2022
Merged
lemeurherve added a commit to jenkins-infra/kubernetes-management that referenced this issue May 25, 2022
@lemeurherve
feat: use Jenkins Infra inbound-agent Windows Docker image (#2404)
cca94d5 
* feat: use Jenkins Infra inbound-agent Windows Docker image

Ref: jenkins-infra/helpdesk#2873

* add a label so we can target this windows template in manual (replay) tests
lemeurherve pushed a commit to jenkins-infra/docker-inbound-agents that referenced this issue May 25, 2022
@lemeurherveCB
feat: activate semversionning on windowsservercore-1809 image
85dedac 
Related: jenkins-infra/helpdesk#2873
@lemeurherve lemeurherve mentioned this issue May 27, 2022
Closed
lemeurherve pushed a commit to lemeurherve/packer-images that referenced this issue May 30, 2022
@lemeurherveCB
fix: install git for Windows with choco so we can chose to not instal…
2510749 
…l Git Credential Manager

Related: jenkins-infra/helpdesk#2873
@lemeurherve lemeurherve mentioned this issue May 30, 2022
Closed
lemeurherve pushed a commit to lemeurherve/packer-images that referenced this issue May 30, 2022
@lemeurherveCB
fix: install git for Windows with choco so we can chose to not instal…
d32e9b4 
…l Git Credential Manager

Related: jenkins-infra/helpdesk#2873
This was referenced May 30, 2022
Closed
Merged
Merged
lemeurherve pushed a commit to lemeurherve/kubernetes-management that referenced this issue Jun 7, 2022
@lemeurherveCB
feat(release): use Jenkins Infra inbound-agent Windows Docker image
0a973ae 
Ref: jenkins-infra/helpdesk#2873
Related: jenkins-infra#2404
lemeurherve pushed a commit to lemeurherve/kubernetes-management that referenced this issue Jun 7, 2022
@lemeurherveCB
feat(release): use Jenkins Infra inbound-agent Windows Docker image
681943d 
Ref: jenkins-infra/helpdesk#2873
Related:
- jenkins-infra#2404
- jenkins-infra#2434
@lemeurherve lemeurherve mentioned this issue Jun 7, 2022
Merged
lemeurherve pushed a commit to lemeurherve/jenkins-infra that referenced this issue Jun 7, 2022
@lemeurherveCB
feat: use Jenkins Infra inbound-agent Windows Docker image
fbdb546 
Ref: jenkins-infra/helpdesk#2873
@lemeurherve lemeurherve mentioned this issue Jun 7, 2022
Merged
dduportal pushed a commit to jenkins-infra/kubernetes-management that referenced this issue Jun 7, 2022
@lemeurherve
feat(release): use Jenkins Infra inbound-agent Windows Docker image (#…
6eff97c 
…2468)

Ref: jenkins-infra/helpdesk#2873
Related:
- #2404
- #2434
lemeurherve added a commit to jenkins-infra/jenkins-infra that referenced this issue Jun 7, 2022
@lemeurherve
feat: use Jenkins Infra inbound-agent Windows Docker image (#2203)
5a67070 
Ref: jenkins-infra/helpdesk#2873
@dduportal
Copy link
Contributor Author

Sounds like it's working @lemeurherve . I'll let you close the issue if ok for you. Great job!

@dduportal dduportal removed the triage Incoming issues that need review label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lemeurherve lemeurherve

Labels
ci.jenkins.io docker infra.ci.jenkins.io release.ci.jenkins.io site:ci.jenkins.io trusted.ci.jenkins.io windows
Projects
None yet
Milestone
infra-team-sync-2022-06-07
Development

No branches or pull requests
2 participants
@dduportal @lemeurherve