From 38c1672cb54995fd6d80468ed2eb19430c5e514a Mon Sep 17 00:00:00 2001
From: Valentin Delaye <jonesbusy@users.noreply.github.com>
Date: Wed, 11 Dec 2024 17:26:03 +0100
Subject: [PATCH] Optimize far jar (#445)

* First jar optimization to reduce it's size

* Remove some test dependencies and only include rewrite-core from CLI
---
 plugin-modernizer-cli/pom.xml  | 17 +++++++++++++++++
 plugin-modernizer-core/pom.xml | 17 ++++++++++++-----
 pom.xml                        |  9 +++++----
 3 files changed, 34 insertions(+), 9 deletions(-)

diff --git a/plugin-modernizer-cli/pom.xml b/plugin-modernizer-cli/pom.xml
index b48b45d5..5ece97bb 100644
--- a/plugin-modernizer-cli/pom.xml
+++ b/plugin-modernizer-cli/pom.xml
@@ -27,6 +27,23 @@
       <groupId>io.jenkins.plugin-modernizer</groupId>
       <artifactId>plugin-modernizer-core</artifactId>
       <version>${changelist}</version>
+      <!-- We never use OpenRewrite directly from CLI because of maven invoker which will download the core module and it's dependencies -->
+      <exclusions>
+        <exclusion>
+          <groupId>org.openrewrite</groupId>
+          <artifactId>*</artifactId>
+        </exclusion>
+      </exclusions>
+    </dependency>
+    <!-- We only use the Recipe class and Xml.Tag from the CLI -->
+    <!-- TODO : We should be able to break this dependencies by introducing our own interfaces -->
+    <dependency>
+      <groupId>org.openrewrite</groupId>
+      <artifactId>rewrite-core</artifactId>
+    </dependency>
+    <dependency>
+      <groupId>org.openrewrite</groupId>
+      <artifactId>rewrite-xml</artifactId>
     </dependency>
     <dependency>
       <groupId>org.slf4j</groupId>
diff --git a/plugin-modernizer-core/pom.xml b/plugin-modernizer-core/pom.xml
index a50e4c85..a32ac174 100644
--- a/plugin-modernizer-core/pom.xml
+++ b/plugin-modernizer-core/pom.xml
@@ -133,16 +133,17 @@
     <dependency>
       <groupId>org.openrewrite.recipe</groupId>
       <artifactId>rewrite-testing-frameworks</artifactId>
+      <exclusions>
+        <exclusion>
+          <groupId>org.testcontainers</groupId>
+          <artifactId>testcontainers</artifactId>
+        </exclusion>
+      </exclusions>
     </dependency>
     <dependency>
       <groupId>org.slf4j</groupId>
       <artifactId>slf4j-api</artifactId>
     </dependency>
-    <dependency>
-      <groupId>uk.org.webcompere</groupId>
-      <artifactId>system-stubs-jupiter</artifactId>
-      <version>2.1.7</version>
-    </dependency>
     <dependency>
       <groupId>io.jsonwebtoken</groupId>
       <artifactId>jjwt-impl</artifactId>
@@ -159,6 +160,12 @@
       <artifactId>rewrite-test</artifactId>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>uk.org.webcompere</groupId>
+      <artifactId>system-stubs-jupiter</artifactId>
+      <version>2.1.7</version>
+      <scope>test</scope>
+    </dependency>
   </dependencies>
 
   <build>
diff --git a/pom.xml b/pom.xml
index bd25d428..1f2a02a0 100644
--- a/pom.xml
+++ b/pom.xml
@@ -263,10 +263,6 @@
   </dependencyManagement>
 
   <dependencies>
-    <dependency>
-      <groupId>org.mockito</groupId>
-      <artifactId>mockito-junit-jupiter</artifactId>
-    </dependency>
     <dependency>
       <groupId>org.junit.jupiter</groupId>
       <artifactId>junit-jupiter-api</artifactId>
@@ -282,6 +278,11 @@
       <artifactId>mockito-core</artifactId>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>org.mockito</groupId>
+      <artifactId>mockito-junit-jupiter</artifactId>
+      <scope>test</scope>
+    </dependency>
     <dependency>
       <groupId>org.wiremock</groupId>
       <artifactId>wiremock-standalone</artifactId>