Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display the reason for a pipeline being timed out or cancelled #23

Open
ankitm123 opened this issue May 27, 2022 · 2 comments
Open

Display the reason for a pipeline being timed out or cancelled #23

ankitm123 opened this issue May 27, 2022 · 2 comments
Labels
easy gsoc2022 priority/critical-urgent
Milestone
MVP

Comments

@ankitm123
Copy link
Member

When a pipeline is cancelled or it has timedout, we update the status of the pipeline to cancelled or timedout.
But we dont show any reason why a job was timedout.
Some of the possible reasons could be:

  • Docker registry was down
  • Jobs could not complete in the timeout set in the pipeline file
  • Nodes were not provisioned, and hence the jobs timed out

We should show that information in the pipeline details page (along with the step which has timed out).

This will most likely involve making changes in the jx-api repo (adding a new field to the pipeline activity struct).
@rajatgupta24 rajatgupta24 mentioned this issue Jun 16, 2022
Closed
@ankitm123
Copy link
Member Author

@rajatgupta24 is working on this.

@rajatgupta24 rajatgupta24 mentioned this issue Jul 2, 2022
Merged
@ankitm123 ankitm123 added this to the MVP milestone Jul 6, 2022
rajatgupta24 added a commit to rajatgupta24/jx-api that referenced this issue Jul 7, 2022
@rajatgupta24
feat: add new msg field to spec struct
84c5994 
related to jenkins-x/jx-ui#23

This PR adds a message field in Spec and Steps structs to hold the messages provided by tekton PipelineRun.
rajatgupta24 added a commit to rajatgupta24/jx-api that referenced this issue Jul 7, 2022
@rajatgupta24
feat: add new msg field to spec struct
6eb3061 
related to jenkins-x/jx-ui#23

This PR adds a message field in Spec and Steps structs to hold the messages provided by tekton PipelineRun.
rajatgupta24 added a commit to rajatgupta24/jx-pipeline that referenced this issue Jul 7, 2022
@rajatgupta24
fix: add msg field to pipelineActivity Spec and Steps
f7130d5 
- Tekton PipelineRun provides the message & this PR will add that Message field to Spec and Steps in the pipelineActivity.
- This PR also adds test for 4 testcases:
	- timeout
	- cancelled
	- success
	- timedout-success

related to jenkins-x/jx-ui#23

Signed-off-by: rajatgupta24 <[email protected]>
@rajatgupta24 rajatgupta24 mentioned this issue Jul 7, 2022
Merged
rajatgupta24 added a commit to rajatgupta24/jx-pipeline that referenced this issue Jul 8, 2022
@rajatgupta24
fix: add msg field to pipelineActivity Spec and Steps
cbccbf8 
- Tekton PipelineRun provides the message & this PR will add that Message field to Spec and Steps in the pipelineActivity.
- This PR also adds test for 4 testcases:
	- timeout
	- cancelled
	- success
	- timedout-success

related to jenkins-x/jx-ui#23

Signed-off-by: rajatgupta24 <[email protected]>
rajatgupta24 added a commit to rajatgupta24/jx-pipeline that referenced this issue Jul 9, 2022
@rajatgupta24
fix: add msg field to pipelineActivity Spec and Steps
c0fde1b 
- Tekton PipelineRun provides the message & this PR will add that Message field to Spec and Steps in the pipelineActivity.
- This PR also adds test for 4 testcases:
	- timeout
	- cancelled
	- success
	- timedout-success

related to jenkins-x/jx-ui#23

Signed-off-by: rajatgupta24 <[email protected]>
rajatgupta24 added a commit to rajatgupta24/jx-pipeline that referenced this issue Jul 13, 2022
@rajatgupta24
fix: add msg field to pipelineActivity Spec and Steps
7d50b6c 
- Tekton PipelineRun provides the message & this PR will add that Message field to Spec and Steps in the pipelineActivity.
- This PR also adds test for 4 testcases:
	- timeout
	- cancelled
	- success
	- timedout-success
- This also adds the message fields to the expected.yaml.
- Instead of using `testhelpers.AssertTextFilesEqual` we're now just comparing the generated pa and expected pa.
- Also removes `t.TempDir()`
- Adds comments to help understand the steps

related to jenkins-x/jx-ui#23

Signed-off-by: rajatgupta24 <[email protected]>
@ankitm123
Copy link
Member Author

To be shown in the office hours on Aug 2, 2022

rajatgupta24 added a commit to rajatgupta24/jx-pipeline that referenced this issue Sep 14, 2022
@rajatgupta24
fix: add msg field to pipelineActivity Spec and Steps
d832475 
- Tekton PipelineRun provides the message & this PR will add that Message field to Spec and Steps in the pipelineActivity.
- This PR also adds test for 4 testcases:
	- timeout
	- cancelled
	- success
	- timedout-success
- This also adds the message fields to the expected.yaml.
- Instead of using `testhelpers.AssertTextFilesEqual` we're now just comparing the generated pa and expected pa.
- Also removes `t.TempDir()`
- Adds comments to help understand the steps

related to jenkins-x/jx-ui#23

Signed-off-by: rajatgupta24 <[email protected]>
rajatgupta24 added a commit to rajatgupta24/jx-pipeline that referenced this issue Sep 14, 2022
@rajatgupta24
fix: add msg field to pipelineActivity Spec and Steps
97f4a8d 
- Tekton PipelineRun provides the message & this PR will add that Message field to Spec and Steps in the pipelineActivity.
- This PR also adds test for 4 testcases:
	- timeout
	- cancelled
	- success
	- timedout-success
- This also adds the message fields to the expected.yaml.
- Instead of using `testhelpers.AssertTextFilesEqual` we're now just comparing the generated pa and expected pa.
- Also removes `t.TempDir()`
- Adds comments to help understand the steps

related to jenkins-x/jx-ui#23

Signed-off-by: rajatgupta24 <[email protected]>
rajatgupta24 added a commit to rajatgupta24/jx-pipeline that referenced this issue Sep 15, 2022
@rajatgupta24
fix: add msg field to pipelineActivity Spec and Steps
14e5a8d 
- Tekton PipelineRun provides the message & this PR will add that Message field to Spec and Steps in the pipelineActivity.
- This PR also adds test for 4 testcases:
	- timeout
	- cancelled
	- success
	- timedout-success
- This also adds the message fields to the expected.yaml.
- Instead of using `testhelpers.AssertTextFilesEqual` we're now just comparing the generated pa and expected pa.
- Also removes `t.TempDir()`
- Adds comments to help understand the steps
- fixes linter.sh

related to jenkins-x/jx-ui#23

Signed-off-by: rajatgupta24 <[email protected]>
rajatgupta24 added a commit to rajatgupta24/jx-pipeline that referenced this issue Sep 16, 2022
@rajatgupta24
fix: add msg field to pipelineActivity Spec and Steps
5a77bd7 
- Tekton PipelineRun provides the message & this PR will add that Message field to Spec and Steps in the pipelineActivity.
- This PR also adds test for 4 testcases:
	- timeout
	- cancelled
	- success
	- timedout-success
- This also adds the message fields to the expected.yaml.
- Instead of using `testhelpers.AssertTextFilesEqual` we're now just comparing the generated pa and expected pa.
- Also removes `t.TempDir()`
- Adds comments to help understand the steps
- fixes linter.sh

related to jenkins-x/jx-ui#23

Signed-off-by: rajatgupta24 <[email protected]>
@msvticket msvticket moved this to In progress in Public roadmap Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy gsoc2022 priority/critical-urgent
Projects
Public roadmap
Archived in project
Milestone
MVP
Development

No branches or pull requests
1 participant
@ankitm123