Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make matrix-project optional dependency #683

Open
jonesbusy opened this issue Jul 16, 2024 · 5 comments · May be fixed by #757
Open

Make matrix-project optional dependency #683

jonesbusy opened this issue Jul 16, 2024 · 5 comments · May be fixed by #757
Labels

Comments

@jonesbusy
Copy link
Contributor

What feature do you want to see added?

In a 100% pipeline Jenkins this plugin should not force installing the matrix-project.

Please consider making it optional

Similar to jenkinsci/htmlpublisher-plugin#287

Upstream changes

No response

Are you interested in contributing this feature?

No response

@ahmad-kashkoush
Copy link

ahmad-kashkoush commented Feb 25, 2025

Hi, @jonesbusy
I've searched for the solution and My approach will be like:

  • Add Optional true option in Pom.xml
  • Check classes that require loading matrix project configuration.

For The classes part I found that classes:

  • return if type of item.task or build is MatrixBuild or MatrixProject
  • put MatrixConfiguration combination into params or env I guess that where we should load configuration

how to show the change in the PR for solving this issue?
May you correct me if I'm wrong, or give me any insight ?

@ahmad-kashkoush
Copy link

ahmad-kashkoush commented Feb 27, 2025

@jonesbusy may you help me on this one?

@jonesbusy
Copy link
Contributor Author

I'm not maintainer of this plugin

@jonesbusy
Copy link
Contributor Author

There are many other PR removing this hard dependency jenkinsci/htmlpublisher-plugin#287

Did you take a look at it?

@ahmad-kashkoush
Copy link

There are many other PR removing this hard dependency jenkinsci/htmlpublisher-plugin#287

Did you take a look at it?

yes, I've done so.
thanks for your reply I'll do what I can

@ahmad-kashkoush ahmad-kashkoush linked a pull request Feb 27, 2025 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants