Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not have a trace for every job? #20

Open
JVMartin opened this issue Apr 12, 2024 · 2 comments
Open

Why not have a trace for every job? #20

JVMartin opened this issue Apr 12, 2024 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@JVMartin
Copy link

Very strange setup here - there is a single trace for the entire queue processor, and each job processed is merely a span in that huuuge trace:
image

Why not have a trace for every job instead? We want to be able to figure out which particular jobs are slow so we can identify them.

@jenniferplusplus
Copy link
Owner

I would be open to a config option to set that behavior. I don't actually work with bullmq on any of my own projects anymore, so I don't use this instrumentation myself anymore, and I don't have a good way to exercise it. But I'd be happy to accept a PR.

@jenniferplusplus jenniferplusplus added the help wanted Extra attention is needed label May 21, 2024
@unflxw
Copy link

unflxw commented Jun 26, 2024

Hi @JVMartin,

In case you find this useful, we've implemented this change (along with other changes) in our fork of the instrumentation, over at https://github.com/appsignal/opentelemetry-instrumentation-bullmq.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants