Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing options directly to Puppeteer's Page.goto() function #17

Open
jerboa88 opened this issue Jun 4, 2024 · 0 comments
Open
Labels
feature New feature or request
Milestone

Comments

@jerboa88
Copy link
Owner

jerboa88 commented Jun 4, 2024

Remove hardcoded PUPPETEER_WAIT_CONDITION constant and allow options to be passed directly to Puppeteer's Page.goto(), along with other options, like so:

setDefaultOptions({
  puppeteer: {
    goto: {
      timeout: 10000,
      waitUntil: 'networkidle2',
      // ...
    },
    // ...
  },
  // ...
})

Allowing arbitrary options to be passed will give user's more flexibility in case they need to customize the behavior of Page.goto() for their use case.

@jerboa88 jerboa88 added this to the v2.0.0 milestone Jun 10, 2024
@jerboa88 jerboa88 added the feature New feature or request label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant