Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FP]: False Positive for msal4j-persistence-extension-1.3.0.jar against CVE-2024-35255 #7238

Closed
jubui opened this issue Dec 9, 2024 · 5 comments
Labels
FP Report maven changes to the maven plugin

Comments

@jubui
Copy link

jubui commented Dec 9, 2024

Package URl

pkg:maven/com.microsoft.azure/[email protected]

CPE

cpe:2.3:a:microsoft:authentication_library:1.3.0:*:*:*:*:*:*:*

CVE

CVE-2024-35255

ODC Integration

None

ODC Version

10.0.3

Description

The persistence-extension library is part of the msal4j project and as such, it doesn't make sense to compare the persistence-extension version (in this case v1.3.0) against the msal4j version number (in this case versions <1.15.1 are affected).

Furthermore, https://msrc.microsoft.com/update-guide/vulnerability/CVE-2024-35255 indicates that the java ManagedIdentityApplication class is vulnerable, which is in the msal4j library, not the msal4j-persistence-extension submodule.

@jubui jubui added the FP Report label Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Failed to automatically evaluate the false positive. See: https://github.com/jeremylong/DependencyCheck/actions/runs/12241787047

@chadlwilson
Copy link
Contributor

Can you please edit the description to trigger the bot to run again? (I dont have permissions to nudge it and it seems it had a transient error with Maven Central)

This seems a false positive as the extension is versioned independently of the main msal4j artifact.

Copy link
Contributor

Maven Coordinates

<dependency>
   <groupId>com.microsoft.azure</groupId>
   <artifactId>msal4j-persistence-extension</artifactId>
   <version>1.3.0</version>
</dependency>

Suppression rule:

<suppress base="true">
   <notes><![CDATA[
   FP per issue #7238
   ]]></notes>
   <packageUrl regex="true">^pkg:maven/com\.microsoft\.azure/msal4j-persistence-extension@.*$</packageUrl>
   <cpe>cpe:/a:microsoft:authentication_library</cpe>
</suppress>

Link to test results: https://github.com/jeremylong/DependencyCheck/actions/runs/12256383851

@github-actions github-actions bot added the maven changes to the maven plugin label Dec 10, 2024
@chadlwilson
Copy link
Contributor

Approved

Copy link
Contributor

Suppress rule has been added to the generatedSuppressions branch.

github-actions bot added a commit that referenced this issue Dec 10, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FP Report maven changes to the maven plugin
Projects
None yet
Development

No branches or pull requests

2 participants