Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling for cases in which sub image does not fit on top of base image #1

Open
jerry-git opened this issue Mar 17, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@jerry-git
Copy link
Owner

For example, if cigar/glasses image does not fit on top of the original image, the traceback is something like this:

File "/Users/user/.virtualenvs/user-venv/lib/python3.5/site-packages/thug/meme/thug.py", line 122, in _draw_on_top background = cv2.bitwise_and(background, background, mask=mask_inv) cv2.error: /Users/travis/build/skvark/opencv-python/opencv/modules/core/src/arithm.cpp:241: error: (-215) (mtype == 0 || mtype == 1) && _mask.sameSize(*psrc1) in function binary_op

Better exception is at least required. Best solution would probably be automatic rescaling of the sub image (cigar/glasses).

@jerry-git jerry-git added the bug Something isn't working label Mar 17, 2018
jerry-git added a commit that referenced this issue Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant